lkml.org 
[lkml]   [2012]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/36] atomic64_test: Simplify the #ifdef for atomic64_dec_if_positive() test
On Wed, Jul 18, 2012 at 05:33:57AM +0100, Benjamin Herrenschmidt wrote:
> On Fri, 2012-07-06 at 22:05 +0100, Catalin Marinas wrote:
> > This patch introduces ARCH_HAS_ATOMIC64_DEC_IF_POSITIVE and uses this
> > instead of the multitude of #if defined() checks in atomic64_test.c
> >
> > Signed-off-by: Will Deacon <will.deacon@arm.com>
> > Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
>
> I'll let other paint the bike shed as to whether ARCH_HAS_* is the right
> thing here, but as far as the powerpc change is concerned:
>
> Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

Thanks Ben. I followed Andrew's feedback to some other patches that Will
posted and moved the #define to Kconfig:

https://lkml.org/lkml/2012/7/17/382

I don't have any strong preference.

--
Catalin


\
 
 \ /
  Last update: 2012-07-18 12:01    [from the cache]
©2003-2011 Jasper Spaans