Messages in this thread |  | | | Subject | Re: [PATCH 1/4] ACPI: Add acpi_pr_<level>() interfaces | | From | Joe Perches <> | | Date | Wed, 18 Jul 2012 14:27:56 -0700 |
| |
On Wed, 2012-07-18 at 14:40 -0600, Toshi Kani wrote: > This patch introduces acpi_pr_<level>(), where <level> is a message > level such as err/warn/info, to support improved logging messages > for ACPI, esp. in hotplug operations.
One more note:
> diff --git a/drivers/acpi/utils.c b/drivers/acpi/utils.c [] > @@ -454,3 +454,35 @@ acpi_evaluate_hotplug_ost(acpi_handle handle, u32 source_event, [] > +void > +acpi_printk(const char *level, acpi_handle handle, const char *fmt, ...) [] > + struct acpi_buffer buffer = {ACPI_ALLOCATE_BUFFER}; [] > + ret = acpi_get_name(handle, ACPI_FULL_PATHNAME, &buffer); [] > + kfree(buffer.pointer);
There's a failure mode here because buffer.pointer isn't guaranteed to be initialized or set to NULL.
|  |