lkml.org 
[lkml]   [2012]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCHv3 0/3] perf tool: Add new event group management
    On Wed, Jul 18, 2012 at 08:34:10AM -0400, Ulrich Drepper wrote:
    > On Wed, Jul 18, 2012 at 6:21 AM, Jiri Olsa <jolsa@redhat.com> wrote:
    > > Well, I personally like the '{}' syntax more than '--group-events or --group-reads
    > > option in front', it feels more user friendly.. anyway, we can easily have both ways.
    >
    > I like the actual visual grouping better, too.
    >
    > Also, it doesn't require us to define what
    >
    > -e E1,E2 --group-events -e E3,E4
    >
    > means. Does --group-events also apply to the first parameter?
    >
    >
    > > As for the group attributes and group leader sampling, I don't mind omitting
    > > them at this point and get back to that if we find it useful in future.
    >
    > Just define the first event the leader. What reason is there which
    > prevents this?

    yep, no problem.. first one is the leader

    The group sampling is just another feature where you enable sampling
    only for the leader and the rest of the events in the group are only
    being read on leader's sample - they don't sample by themselves.

    But this feature needs more testing, and event modifier syntax rethinking ;)
    I'll send it later..

    > I can only second what Andi wrote: just get it done quickly. This is
    > functionality that is desperately needed.

    I have new patchset ready with group modifiers adding modifiers
    to events in the group, like:

    {cycles:u,instructions:u}:p

    adds 'p' to both events in the group
    (in current patchset group modifier overwrites events modifiers)

    if there's strong opinion/reasons against it, I can simply remove
    it, but it looks helpful

    jirka


    \
     
     \ /
      Last update: 2012-07-18 22:41    [W:3.495 / U:0.512 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site