lkml.org 
[lkml]   [2012]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH] debug: Do not permit CONFIG_DEBUG_STACK_USAGE=y on IA64 or PARISC
    The stack_not_used() function in <linux/sched.h> assumes that stacks
    grow downwards. This is not true on IA64 or PARISC, so this function
    would walk off in the wrong direction and into the weeds.

    Found on IA64 because of a compilation failure with recursive dependencies
    on IA64_TASKSIZE and IA64_THREAD_INFO_SIZE.

    Fixing the code is possible, but should be combined with other
    infrastructure additions to set up the "canary" at the end of the stack.

    Reported-by: Fengguang Wu <fengguang.wu@intel.com> (failed allmodconfig build)
    Signed-off-by: Tony Luck <tony.luck@intel.com>
    ---
    lib/Kconfig.debug | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
    index ff5bdee..4a18650 100644
    --- a/lib/Kconfig.debug
    +++ b/lib/Kconfig.debug
    @@ -714,7 +714,7 @@ config STACKTRACE

    config DEBUG_STACK_USAGE
    bool "Stack utilization instrumentation"
    - depends on DEBUG_KERNEL
    + depends on DEBUG_KERNEL && !IA64 && !PARISC
    help
    Enables the display of the minimum amount of free stack which each
    task has ever had available in the sysrq-T and sysrq-P debug output.
    --
    1.7.10.2.552.gaa3bb87


    \
     
     \ /
      Last update: 2012-07-18 20:41    [W:0.023 / U:0.964 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site