lkml.org 
[lkml]   [2012]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 2/3] cgroup: revise how we re-populate root directory
Hello,

On Wed, Jul 18, 2012 at 10:16:05AM -0400, Aristeu Rozanski wrote:
> > Yeah, generally looks good to me although @added/removed_bits argument
> > names irk me a bit. The name may be okay for local variables but I
> > keep thinking "what bits?". @subsys_mask or something indicating that
> > it's mask of subsystems would better. Also, can you please add /**
> > function comment explaining the clear/populate functions and their
> > arguments?
>
> agreed. although the "_bits" thing is spread all around the code. you
> want that cleaned up too? (I can post a followup patch after this
> patchset is done)

Yeah, that would be great.

Thanks a lot!

--
tejun


\
 
 \ /
  Last update: 2012-07-18 19:21    [W:0.373 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site