lkml.org 
[lkml]   [2012]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCHv3 0/3] perf tool: Add new event group management
On Wed, Jul 18, 2012 at 6:21 AM, Jiri Olsa <jolsa@redhat.com> wrote:
> Well, I personally like the '{}' syntax more than '--group-events or --group-reads
> option in front', it feels more user friendly.. anyway, we can easily have both ways.

I like the actual visual grouping better, too.

Also, it doesn't require us to define what

-e E1,E2 --group-events -e E3,E4

means. Does --group-events also apply to the first parameter?


> As for the group attributes and group leader sampling, I don't mind omitting
> them at this point and get back to that if we find it useful in future.

Just define the first event the leader. What reason is there which
prevents this?


I can only second what Andi wrote: just get it done quickly. This is
functionality that is desperately needed.


\
 
 \ /
  Last update: 2012-07-18 15:21    [W:0.336 / U:0.212 seconds]
©2003-2014 Jasper Spaans. Advertise on this site