lkml.org 
[lkml]   [2012]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] rbtree: fix jffs2 build issue due to renamed __rb_parent_color field
From
Date
On Wed, 2012-07-18 at 04:31 -0700, Michel Lespinasse wrote:
> Fix this and add a comment explaining why this direct use is safe
> here.

Note that there was already a comment which was *intended* to have that
effect, right before the assignment:

/* Colour doesn't matter now. Only the parent pointer. */

If you're going to make that comment redundant, you might as well remove
it. And you might as well say that the trees are being *destroyed*
(consumed) at this point, rather than just that there will be no further
insert or erase operations.

--
dwmw2
[unhandled content-type:application/x-pkcs7-signature]
\
 
 \ /
  Last update: 2012-07-18 14:22    [W:0.041 / U:0.380 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site