lkml.org 
[lkml]   [2012]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RESEND PATCH 1/2] mfd: add irq domain support for max8997 interrupts
On Wed, Jul 18, 2012 at 10:48:04AM +0900, Chanwoo Choi wrote:
> On 07/18/2012 01:34 AM, Greg KH wrote:
>
> > On Mon, Jul 02, 2012 at 09:02:55AM +0900, Chanwoo Choi wrote:
> >> From: Thomas Abraham <thomas.abraham@linaro.org>
> >>
> >> Add irq domain support for max8997 interrupts. The reverse mapping method
> >> used is linear mapping since the sub-drivers of max8997 such as regulator
> >> and charger drivers can use the max8997 irq_domain to get the linux irq
> >> number for max8997 interrupts. All uses of irq_base in platform data and
> >> max8997 driver private data are removed.
> >>
> >> Signed-off-by: Thomas Abraham <thomas.abraham@linaro.org>
> >> Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>
> >> Acked-by: Grant Likely <grant.likely@secretlab.ca>
> >> Acked-by: Samuel Ortiz <sameo@linux.intel.com>
> >> [Fix two bug which set max8997->irq_domain and correct wrong parameter]
> >> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> >> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> >> ---
> >> arch/arm/mach-exynos/mach-nuri.c | 4 --
> >> arch/arm/mach-exynos/mach-origen.c | 1 -
> >> drivers/mfd/Kconfig | 1 +
> >> drivers/mfd/max8997-irq.c | 62 +++++++++++++++++++++--------------
> >> drivers/mfd/max8997.c | 1 -
> >> include/linux/mfd/max8997-private.h | 4 ++-
> >> include/linux/mfd/max8997.h | 1 -
> >> 7 files changed, 41 insertions(+), 33 deletions(-)
> >
> > Once again, this patch breaks the build.
> >
> > Please be more careful with your patches, and TEST THEM BEFORE SENDING
> > THEM OUT.
> >
>
>
> I have posted patchset including below two patch. If only first patch is
> applied to build test, this patch breaks the build. The second patch fix
> that extcon-max8997 driver use irq_domain instead of irq_base field in
> 'struct max8997_dev'.
>
> [PATCH v3 1/2] mfd: add irq domain support for max8997 interrupts
> [PATCH v3 2/2] Extcon: MAX8997: Add support irq domain for MAX8997 muic
>
> Please apply second patch when test this patchset.

No. You can not break the build at any point in the patch series
process, sorry. Each patch must be stand-alone and correct.

greg k-h


\
 
 \ /
  Last update: 2012-07-18 07:21    [W:1.092 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site