lkml.org 
[lkml]   [2012]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 04/17] pda_power: remove IRQF_SAMPLE_RANDOM which is now a no-op
    On Tue, Jul 17, 2012 at 05:32:23PM -0400, Theodore Ts'o wrote:
    > With the changes in the random tree, IRQF_SAMPLE_RANDOM is now a
    > no-op; interrupt randomness is now collected unconditionally in a very
    > low-overhead fashion; see commit 775f4b297b. The IRQF_SAMPLE_RANDOM
    > flag was scheduled to be removed in 2009 on the
    > feature-removal-schedule, so this patch is preparation for the final
    > removal of this flag.
    >
    > Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
    > Cc: Anton Vorontsov <cbou@mail.ru>
    > Cc: David Woodhouse <dwmw2@infradead.org>
    > ---

    Applied, thanks!

    > drivers/power/pda_power.c | 6 +-----
    > 1 file changed, 1 insertion(+), 5 deletions(-)
    >
    > diff --git a/drivers/power/pda_power.c b/drivers/power/pda_power.c
    > index 214468f..db5c526 100644
    > --- a/drivers/power/pda_power.c
    > +++ b/drivers/power/pda_power.c
    > @@ -24,11 +24,7 @@
    >
    > static inline unsigned int get_irq_flags(struct resource *res)
    > {
    > - unsigned int flags = IRQF_SAMPLE_RANDOM | IRQF_SHARED;
    > -
    > - flags |= res->flags & IRQF_TRIGGER_MASK;
    > -
    > - return flags;
    > + return IRQF_SHARED | (res->flags & IRQF_TRIGGER_MASK);
    > }
    >
    > static struct device *dev;

    --
    Anton Vorontsov
    Email: cbouatmailru@gmail.com


    \
     
     \ /
      Last update: 2012-07-18 06:41    [W:0.025 / U:60.316 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site