lkml.org 
[lkml]   [2012]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 2/3] cgroup: revise how we re-populate root directory
    Hello,

    On Tue, Jul 17, 2012 at 05:29:27PM -0400, Aristeu Rozanski wrote:
    > what about this version:

    Yeah, generally looks good to me although @added/removed_bits argument
    names irk me a bit. The name may be okay for local variables but I
    keep thinking "what bits?". @subsys_mask or something indicating that
    it's mask of subsystems would better. Also, can you please add /**
    function comment explaining the clear/populate functions and their
    arguments?

    Thanks!

    --
    tejun


    \
     
     \ /
      Last update: 2012-07-18 04:01    [W:3.169 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site