[lkml]   [2012]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[ 12/23] cfg80211: check iface combinations only when iface is running
    From: Greg KH <>

    3.0-stable review patch. If anyone has any objections, please let me know.


    From: Michal Kazior <>

    commit f8cdddb8d61d16a156229f0910f7ecfc7a82c003 upstream.

    Don't validate interface combinations on a stopped
    interface. Otherwise we might end up being able to
    create a new interface with a certain type, but
    won't be able to change an existing interface
    into that type.

    This also skips some other functions when
    interface is stopped and changing interface type.

    Signed-off-by: Michal Kazior <>
    Signed-off-by: Johannes Berg <>
    [Fixes regression introduced by cherry pick of 463454b5dbd8]
    Signed-off-by: Paul Gortmaker <>

    net/wireless/util.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/net/wireless/util.c
    +++ b/net/wireless/util.c
    @@ -807,7 +807,7 @@ int cfg80211_change_iface(struct cfg8021
    ntype == NL80211_IFTYPE_P2P_CLIENT))
    return -EBUSY;

    - if (ntype != otype) {
    + if (ntype != otype && netif_running(dev)) {
    err = cfg80211_can_change_interface(rdev, dev->ieee80211_ptr,
    if (err)

     \ /
      Last update: 2012-07-18 03:21    [W:0.022 / U:107.560 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site