Messages in this thread |  | | | Date | Tue, 17 Jul 2012 12:39:00 -0500 (CDT) | | From | Christoph Lameter <> | | Subject | Re: [PATCH] mm/slub: fix a BUG_ON() when offlining a memory node and CONFIG_SLUB_DEBUG is on |
| |
On Wed, 18 Jul 2012, Jiang Liu wrote:
> From: Jianguo Wu <wujianguo@huawei.com> > > From: Jianguo Wu <wujianguo@huawei.com> > > SLUB allocator may cause a BUG_ON() when offlining a memory node if > CONFIG_SLUB_DEBUG is on. The scenario is: > > 1) when creating kmem_cache_node slab, it cause inc_slabs_node() twice. > early_kmem_cache_node_alloc > ->new_slab > ->inc_slabs_node > ->inc_slabs_node
New slab will not be able to increment the slab counter. It will check that there is no per node structure yet and then skip the inc slabs node.
This suggests that a call to early_kmem_cache_node_alloc was not needed because the per node structure already existed. Lets fix that instead.
|  |