lkml.org 
[lkml]   [2012]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 01/15] Drivers: hv: Format GUIDS as per MSFT standards
    On Sat, Jul 14, 2012 at 01:34:06PM -0700, K. Y. Srinivasan wrote:
    > Format GUIDS as per MSFT standard. This makes interacting with MSFT
    > tool stack easier.
    >
    > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
    > Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>
    > ---
    > drivers/hv/vmbus_drv.c | 4 ++--
    > 1 files changed, 2 insertions(+), 2 deletions(-)
    >
    > diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
    > index a220e57..1f7e54a 100644
    > --- a/drivers/hv/vmbus_drv.c
    > +++ b/drivers/hv/vmbus_drv.c
    > @@ -147,7 +147,7 @@ static ssize_t vmbus_show_device_attr(struct device *dev,
    >
    > if (!strcmp(dev_attr->attr.name, "class_id")) {
    > ret = sprintf(buf, "{%02x%02x%02x%02x-%02x%02x-%02x%02x-"
    > - "%02x%02x%02x%02x%02x%02x%02x%02x}\n",
    > + "%02x%02x-%02x%02x%02x%02x%02x%02x}\n",

    As Joe pointed out, please just use the printk modifier the kernel
    already has for GUIDS, and don't roll your own here. That will work
    properly for you, right?

    thanks,

    greg k-h


    \
     
     \ /
      Last update: 2012-07-17 18:42    [W:0.025 / U:0.396 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site