Messages in this thread | | | Date | Mon, 16 Jul 2012 18:52:01 -0700 | From | Greg KH <> | Subject | Re: [PATCH 01/30] staging: comedi: add pci_dev pointer to comedi_device |
| |
On Wed, Jul 11, 2012 at 02:49:14PM -0700, H Hartley Sweeten wrote: > The pci_dev pointer in the private driver data is used by every > comedi pci driver. Some of them only have the need for the > private data because of this pointer. > > Introduce the pci_dev pointer in the comedi_device struct so it > can be used instead of needing it in the private data. > > Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> > Cc: Ian Abbott <abbotti@mev.co.uk> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- > drivers/staging/comedi/comedidev.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h > index de8c99c..55f2373 100644 > --- a/drivers/staging/comedi/comedidev.h > +++ b/drivers/staging/comedi/comedidev.h > @@ -212,6 +212,8 @@ struct comedi_device { > * DMA_NONE */ > struct device *hw_dev; > > + struct pci_dev *pcidev;
No, the field above this, hw_dev, should be used instead here, as that's what it is there for, right?
Care to rework this series with that change instead?
thanks,
greg k-h
| |