lkml.org 
[lkml]   [2012]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/5] gpio: tps6586x: add gpio support through platform driver
On Sunday 15 July 2012 03:48 AM, Linus Walleij wrote:
> On Fri, Jul 13, 2012 at 12:39 PM, Laxman Dewangan<ldewangan@nvidia.com> wrote:
>
>> Converting the gpio driver of tps6586x to a platform
>> driver in place of registering the gpio through core
>> driver.
>> The motivation of the change is:
>> - This is inline with the mfd drivers implementation.
>> - This will move the related gpio support to gpio driver
>> folder where all gpio related drivers are available.
>> This will be easy the maintenance and enhancement is
>> anything done for gpio.
>> - The gpio functionality can be selected through config
>> variable.
>>
>> Signed-off-by: Laxman Dewangan<ldewangan@nvidia.com>
> Overall this is very, very good and you're doing the right thing.
>
>> --- /dev/null
>> +++ b/drivers/gpio/gpio-tps6586x.c
>> +#include<linux/i2c.h>
> Why?
>

Removed this inclusion as it is not require.

> Reviewed-by: Linus Walleij<linus.walleij@linaro.org>

I will add your reviewed-by in my next patch for easyness.




\
 
 \ /
  Last update: 2012-07-16 09:41    [W:0.077 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site