Messages in this thread | | | Date | Mon, 16 Jul 2012 13:15:47 +0200 (CEST) | From | Thomas Gleixner <> | Subject | Re: [Regression][Revert request] Excessive delay or hang during resume from system suspend due to a hrtimer commit |
| |
On Mon, 16 Jul 2012, Rafael J. Wysocki wrote:
> On Monday, July 16, 2012, Thomas Gleixner wrote: > > On Sun, 15 Jul 2012, Rafael J. Wysocki wrote: > > > To everyone involved: the fact that this change, which was likely to introduce > > > regressions from the look of it alone, has been pushed to Linus (an to -stable > > > at the same time!) so late in the cycle, is seriuosly disappointing. > > > > Well, we spent an massive amount of time in testing, reviewing and > > discussion and it definitely did not break suspend/resume here. > > I'm not saying that you didn't consider it thoroughly, but unfortunately you > did overlook this particular issue, didn't you? > > > This was not pushed without a lot of thoughts and in fact what you are > > seing is another long standing bug in the timekeeping resume code, > > which was just papered over by the incorrect handling of the clock was > > set cases in the other parts of the system. > > > > Does the following patch fix the problem for you ? > > Yes, it does, thanks! > > > @John: Should that clear ntp as well or is it enough to set ntp_error > > to 0 ? > > > > /me really goes on vacation now. > > So who's going to take care of the patch? :-)
I'm still packing gear. So i'll push it into timers/urgent.
| |