lkml.org 
[lkml]   [2012]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH RFT 1/2] regulator: twl: Fix the formula to calculate vsel and voltage for twl6030ldo
    From
    Date

    > On Monday 09 July 2012 04:31 PM, Axel Lin wrote:
    > > 於 一,2012-07-09 於 11:22 +0800,Axel Lin 提到:
    > >> In twl6030ldo_set_voltage, current code use below formula to calculate vsel:
    > >> vsel = (min_uV/1000 - 1000)/100 + 1;
    > >> This is worng because when min_uV is 1000000 uV, vsel is 1.
    > >> It should be 0 in this case.
    >
    > Why? Do you know of any documentation which states this?

    I double check with the datasheet again now.
    You are right in this. So we cannot use linear mapping for
    twl6030ldo_ops here.
    I'm going to send a patch to fix it, I'd appreciate if someone can
    review and test it.


    > > I found a problem that before commit 3e3d3be79c, the voltage tables were
    > > not linear mapping. So why we can convert these voltage mapping table to
    > > Voltage(in mV) = 1000mv + 100mv * (vsel - 1)?
    > >
    > > Did I miss something?
    >
    > All voltage tables before commit '3e3d3be79c' for twl6030 regulators
    > were clearly wrong. They assumed similarity with twl4030 regulators
    > which was not right.

    Good to know that.
    Thanks,
    Axel
    >
    > regards,
    > Rajendra
    >
    > >
    > > Regards,
    > > Axel
    > >
    > >
    >


    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-07-16 13:01    [W:0.023 / U:60.924 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site