lkml.org 
[lkml]   [2012]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [alsa-devel] [PATCH] wss_lib: fix suspend/resume
    At Thu, 12 Jul 2012 23:30:31 +0200,
    Ondrej Zary wrote:
    >
    > By setting SNDRV_PCM_INFO_RESUME, wss_lib claims that it can restore the card
    > state fully on resume. But in fact, it can't as DMA is not restored so any
    > playback/capture running during suspend will fail to continue after resume.
    >
    > Remove SNDRV_PCM_INFO_RESUME flag from pcm info field to fix the problem.
    >
    > Signed-off-by: Ondrej Zary <linux@rainbow-software.org>

    Applied now. Thanks.


    Takashi

    >
    > --- a/sound/isa/wss/wss_lib.c
    > +++ b/sound/isa/wss/wss_lib.c
    > @@ -1456,7 +1456,6 @@ static struct snd_pcm_hardware snd_wss_playback =
    > {
    > .info = (SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_INTERLEAVED |
    > SNDRV_PCM_INFO_MMAP_VALID |
    > - SNDRV_PCM_INFO_RESUME |
    > SNDRV_PCM_INFO_SYNC_START),
    > .formats = (SNDRV_PCM_FMTBIT_MU_LAW | SNDRV_PCM_FMTBIT_A_LAW | SNDRV_PCM_FMTBIT_IMA_ADPCM |
    > SNDRV_PCM_FMTBIT_U8 | SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S16_BE),
    >
    > --
    > Ondrej Zary
    > _______________________________________________
    > Alsa-devel mailing list
    > Alsa-devel@alsa-project.org
    > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
    >


    \
     
     \ /
      Last update: 2012-07-16 12:01    [W:0.021 / U:31.976 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site