Messages in this thread |  | | | Date | Fri, 13 Jul 2012 09:26:32 +0100 | | Subject | Re: [PATCH 3/3] dw_dmac: set default alignment | | From | viresh kumar <> |
| |
It would be nice to keep spear-devel in cc, as this is the second platform that uses this driver.
On Fri, Jul 13, 2012 at 9:09 AM, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > The default values are filled to support at least mem-to-mem tests provided by > dmatest module. It makes sense to choose the 4 bytes (2 least significant bits) > alignment by the default. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/dma/dw_dmac.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c > index 3d061c6..2a19ab6 100644 > --- a/drivers/dma/dw_dmac.c > +++ b/drivers/dma/dw_dmac.c > @@ -1485,6 +1485,12 @@ static int __devinit dw_probe(struct platform_device *pdev) > dw->dma.device_tx_status = dwc_tx_status; > dw->dma.device_issue_pending = dwc_issue_pending; > > + /* Set default alignment */ > + dw->dma.copy_align = 2; > + dw->dma.xor_align = 2; > + dw->dma.pq_align = 2; > + dw->dma.fill_align = 2;
To understand it more, what does this mean? We will not support transfers with unaligned addresses/length to word size?
-- viresh
|  |