Messages in this thread |  | | | Date | Fri, 13 Jul 2012 15:02:46 -0700 | | From | Andrew Morton <> | | Subject | Re: [PATCH 1/2] Moved core dump functionality into its own file |
| |
On Tue, 3 Jul 2012 12:53:34 +0800 Cong Wang <xiyou.wangcong@gmail.com> wrote:
> On Tue, Jul 3, 2012 at 8:38 AM, Alex Kelly <alex.page.kelly@gmail.com> wrote: > > From: Alex <eshink@gmail.com> > > > > This was done in preparation for making core dump functionality optional. > > > > The variable "suid_dumpable" and associated functions are left in fs/exec.c > > because they're used elsewhere, such as in ptrace. > > > > Signed-off-by: Alex Kelly <alex.page.kelly@gmail.com> > > Reviewed-by: Josh Triplett <josh@joshtriplett.org> > > Looks good to me:
Me too, but the first patch conflicts somewhat with a few pending changes in linux-next. I could fix them up, but would prefer that the result be tested. Alex, could you please redo the patches against linux-next or mmotm?
Also, the patch titles could be improved. I suggest
coredump: move core dump functionality into its own file coredump: make core dump functionality optional
Documentation/SubmittingPatches section 15 describes the thinking here.
Thanks.
|  |