lkml.org 
[lkml]   [2012]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Remove easily user-triggerable BUG from generic_setlease
On Fri, Jul 13, 2012 at 10:47:43AM -0700, Linus Torvalds wrote:
> On Fri, Jul 13, 2012 at 10:35 AM, Dave Jones <davej@redhat.com> wrote:
> > This can be trivially triggered from userspace by passing in something unexpected.
>
> Argh. It looks like it would be harmless (apart from the noise),
> except we hold file_lock_lock. Which turns the BUG_ON() into not just
> "noise and kill the process", but "noise and kill the process and
> leave a nasty lock held".

Yeah, box wedged shortly afterwards. Not cool.

> This seems to go back to 3.2, so stable should be cc'd, no?

yeah, definitly. my bad.

Dave



\
 
 \ /
  Last update: 2012-07-13 20:41    [from the cache]
©2003-2011 Jasper Spaans