Messages in this thread | | | Date | Fri, 13 Jul 2012 16:46:45 +0100 | From | Matthew Garrett <> | Subject | Re: [PATCH] Add missing attributes to EFI variable attribute print out from sysfs |
| |
On Fri, Jul 13, 2012 at 09:38:27AM -0600, Khalid Aziz wrote: > if (var->Attributes & 0x4) > str += sprintf(str, "EFI_VARIABLE_RUNTIME_ACCESS\n");
I know you're just following the pattern of the existing code, but could you change these to be more like
if (var->Attributes & EFI_VARIABLE_RUNTIME_ACCESS)
while you're at it? I think that'd be a worthwhile cleanup.
-- Matthew Garrett | mjg59@srcf.ucam.org
| |