lkml.org 
[lkml]   [2012]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 13/16] mm: Micro-optimise slab to avoid a function call
    Date
    Getting and putting objects in SLAB currently requires a function call
    but the bulk of the work is related to PFMEMALLOC reserves which are
    only consumed when network-backed storage is critical. Use an inline
    function to determine if the function call is required.

    Signed-off-by: Mel Gorman <mgorman@suse.de>
    ---
    mm/slab.c | 28 ++++++++++++++++++++++++++--
    1 file changed, 26 insertions(+), 2 deletions(-)

    diff --git a/mm/slab.c b/mm/slab.c
    index 54bbfe4..c32fc28 100644
    --- a/mm/slab.c
    +++ b/mm/slab.c
    @@ -117,6 +117,8 @@
    #include <linux/memory.h>
    #include <linux/prefetch.h>

    +#include <net/sock.h>
    +
    #include <asm/cacheflush.h>
    #include <asm/tlbflush.h>
    #include <asm/page.h>
    @@ -990,7 +992,7 @@ out:
    spin_unlock_irqrestore(&l3->list_lock, flags);
    }

    -static void *ac_get_obj(struct kmem_cache *cachep, struct array_cache *ac,
    +static void *__ac_get_obj(struct kmem_cache *cachep, struct array_cache *ac,
    gfp_t flags, bool force_refill)
    {
    int i;
    @@ -1037,7 +1039,20 @@ static void *ac_get_obj(struct kmem_cache *cachep, struct array_cache *ac,
    return objp;
    }

    -static void ac_put_obj(struct kmem_cache *cachep, struct array_cache *ac,
    +static inline void *ac_get_obj(struct kmem_cache *cachep,
    + struct array_cache *ac, gfp_t flags, bool force_refill)
    +{
    + void *objp;
    +
    + if (unlikely(sk_memalloc_socks()))
    + objp = __ac_get_obj(cachep, ac, flags, force_refill);
    + else
    + objp = ac->entry[--ac->avail];
    +
    + return objp;
    +}
    +
    +static void *__ac_put_obj(struct kmem_cache *cachep, struct array_cache *ac,
    void *objp)
    {
    if (unlikely(pfmemalloc_active)) {
    @@ -1047,6 +1062,15 @@ static void ac_put_obj(struct kmem_cache *cachep, struct array_cache *ac,
    set_obj_pfmemalloc(&objp);
    }

    + return objp;
    +}
    +
    +static inline void ac_put_obj(struct kmem_cache *cachep, struct array_cache *ac,
    + void *objp)
    +{
    + if (unlikely(sk_memalloc_socks()))
    + objp = __ac_put_obj(cachep, ac, objp);
    +
    ac->entry[ac->avail++] = objp;
    }

    --
    1.7.9.2


    \
     
     \ /
      Last update: 2012-07-12 10:22    [W:0.028 / U:126.028 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site