lkml.org 
[lkml]   [2012]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 181/187] drivers/rtc/rtc-spear.c: fix use-after-free in spear_rtc_remove()
    Date
    From: Greg KH <gregkh@linuxfoundation.org>

    3.4-stable review patch. If anyone has any objections, please let me know.

    ------------------

    From: Devendra Naga <devendra.aaru@gmail.com>

    commit 2a643893e50fde71d7ba84b5592ec61b467b9ab6 upstream.

    `config' is freed and is then used in the rtc_device_unregister() call,
    causing a kernel panic.

    Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
    Reviewed-by: Viresh Kumar <viresh.linux@gmail.com>
    Cc: Alessandro Zummo <a.zummo@towertech.it>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/rtc/rtc-spear.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/rtc/rtc-spear.c
    +++ b/drivers/rtc/rtc-spear.c
    @@ -457,12 +457,12 @@ static int __devexit spear_rtc_remove(st
    clk_disable(config->clk);
    clk_put(config->clk);
    iounmap(config->ioaddr);
    - kfree(config);
    res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
    if (res)
    release_mem_region(res->start, resource_size(res));
    platform_set_drvdata(pdev, NULL);
    rtc_device_unregister(config->rtc);
    + kfree(config);

    return 0;
    }



    \
     
     \ /
      Last update: 2012-07-13 02:41    [W:2.257 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site