lkml.org 
[lkml]   [2012]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Xen-devel] [PATCH] xen pv-on-hvm: add pfn_is_ram helper for kdump
On Thu, Jul 12, Konrad Rzeszutek Wilk wrote:

> > +++ b/include/xen/interface/hvm/hvm_op.h
> > @@ -43,4 +43,24 @@ struct xen_hvm_pagetable_dying {
> > typedef struct xen_hvm_pagetable_dying xen_hvm_pagetable_dying_t;
> > DEFINE_GUEST_HANDLE_STRUCT(xen_hvm_pagetable_dying_t);
> >
> > +typedef enum {
> > + HVMMEM_ram_rw, /* Normal read/write guest RAM */
> > + HVMMEM_ram_ro, /* Read-only; writes are discarded */
> > + HVMMEM_mmio_dm, /* Reads and write go to the device model */
> > +} hvmmem_type_t;
>
> Does this have to be a typdef?
>
> > +
> > +#define HVMOP_get_mem_type 15
> > +/* Return hvmmem_type_t for the specified pfn. */
> > +struct xen_hvm_get_mem_type {
> > + /* Domain to be queried. */
> > + domid_t domid;
> > + /* OUT variable. */
> > + uint16_t mem_type;
> > + uint16_t pad[2]; /* align next field on 8-byte boundary */
> > + /* IN variable. */
> > + uint64_t pfn;
> > +};
> > +typedef struct xen_hvm_get_mem_type xen_hvm_get_mem_type_t;
>
> Please no typdefs. I can fix this up, but in the future pls don't add
> more of them.

Its just a forward port from what went into linux-2.6.18.


Olaf


\
 
 \ /
  Last update: 2012-07-12 20:42    [W:0.029 / U:1.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site