Messages in this thread | | | Date | Thu, 12 Jul 2012 16:32:15 +0530 | From | Raghavendra K T <> | Subject | Re: [PATCH RFC 1/2] kvm vcpu: Note down pause loop exit |
| |
On 07/12/2012 04:28 PM, Nikunj A Dadhania wrote: > On Wed, 11 Jul 2012 16:22:29 +0530, Raghavendra K T<raghavendra.kt@linux.vnet.ibm.com> wrote: >> On 07/11/2012 02:23 PM, Avi Kivity wrote: >>> >>> This adds some tiny overhead to vcpu entry. You could remove it by >>> using the vcpu->requests mechanism to clear the flag, since >>> vcpu->requests is already checked on every entry. >> >> So IIUC, let's have request bit for indicating PLE, >> >> pause_interception() /handle_pause() >> { >> make_request(PLE_REQUEST) >> vcpu_on_spin() >> >> } >> >> check_eligibility() >> { >> !test_request(PLE_REQUEST) || ( test_request(PLE_REQUEST)&& >> dy_eligible()) >> . >> . >> } >> >> vcpu_run() >> { >> >> check_request(PLE_REQUEST) >> > I know check_request will clear PLE_REQUEST, but you just need a > clear_request here, right? >
Yes. tried to use check_request for clearing. But I ended up in different implementation. (latest thread)
| |