lkml.org 
[lkml]   [2012]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/2] staging/et131x: remove memset for the TCB
From
On Thu, Jul 12, 2012 at 2:21 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Thu, Jul 12, 2012 at 11:54:28AM +0545, Devendra Naga wrote:
>> TCB has kcalloc' ed so no need to call memset again on it.
>>
>
> Gar... What about when this is called from et131x_adjust_link() and
> et1310_disable_phy_coma()?
>
Yeah, i didn't looked those paths, i am sorry.
> Really this changelog is annoying. Based on the changelog I was
> expecting the kcalloc() to be in the same function but it wasn't.
> So then I have to redo all your work and check every code path. You
> could have said what the code paths were in your description so I
> don't have to grovel through it all myself.
>
Ok. will try to put all the info i found while sending patches from next time
> regards,
> dan carpenter
>
>

Thanks,
Devendra.


\
 
 \ /
  Last update: 2012-07-12 12:01    [W:0.886 / U:0.436 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site