lkml.org 
[lkml]   [2012]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/4] [SCSI] ufs: Separate PCI glue driver for ufshcd
From
On Mon, Jul 2, 2012 at 8:47 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Monday 02 July 2012, Vinayak Holikatti wrote:
>>
>> This patch separates PCI and core UFS host controller driver.
>> In the current implementation PCI specific code is with ufshcd.c.
>> To provide way for adding multiple bus glue driver, this patch
>> separates PCI layer from ufshcd core. Now ufshcd compiles as separate
>> module and ufshcd-pci as separate module.
>>
>> Signed-off-by: Vinayak Holikatti <vinholikatti@gmail.com>
>> Signed-off-by: Santosh Yaraganavi <santoshsy@gmail.com>
>
> Hi Vinayak,
>
> This patch looks good at first sight, but it's a little hard to
> review in the form that you are posting.
>
> I would recommend that you split this patch into two separate
> changesets, where you do all the changes to existing code in the
> first patch, and only move but don't change code in the second one
> that creates the new file.
Ok, will spilt accordinglly to make it two changesets.
>
> Arnd


\
 
 \ /
  Last update: 2012-07-11 07:01    [W:0.184 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site