Messages in this thread | | | From | Krystian Garbaciak <> | Subject | Re: [PATCH] regulator: Fix bug in regulator_mode_to_status() core function. | Date | Wed, 11 Jul 2012 16:13:00 +0100 |
| |
> > > This is deliberate. It's not reporting an error, it's reporting an > > > indeterminate status which is a different thing. > > > Ok, then I would propose to use REGULATOR_STATUS_OFF instead of 0, to present > > your deliberate decision here. > > I don't think you're fully understanding "indeterminate" there... the > whole point is that we can't adequately represent the state, making > something up isn't helping things.
Would it make more sense to have some special enum value for that case, let say there would be REGULATOR_STATUS_UNDEFINED?
Returning 0 is interpreted as REGULATOR_STATUS_OFF outside the function. But it may change, if ever the enumeration changes.
| |