lkml.org 
[lkml]   [2012]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/3] panel: Use pr_debug(...) rather than printk(KERN_DEBUG ...)
From
Date
On Tue, 2012-07-10 at 20:22 +0900, Toshiaki Yamane wrote:
> This change is inspired by checkpatch.
[]
> diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
[]
> @@ -1838,9 +1838,8 @@ static void panel_process_inputs(void)
> struct logical_input *input;
>
> #if 0
> - printk(KERN_DEBUG
> - "entering panel_process_inputs with pp=%016Lx & pc=%016Lx\n",
> - phys_prev, phys_curr);
> + pr_debug("entering panel_process_inputs with pp=%016Lx & pc=%016Lx\n",
> + phys_prev, phys_curr);
> #endif

Might as well delete these #if 0 blocks instead

>
> keypressed = 0;
> @@ -2003,8 +2002,8 @@ static struct logical_input *panel_bind_key(char *name, char *press,
> key->fall_time = 1;
>
> #if 0
> - printk(KERN_DEBUG "bind: <%s> : m=%016Lx v=%016Lx\n", name, key->mask,
> - key->value);
> + pr_debug("bind: <%s> : m=%016Lx v=%016Lx\n", name, key->mask,
> + key->value);
> #endif
> strncpy(key->u.kbd.press_str, press, sizeof(key->u.kbd.press_str));
> strncpy(key->u.kbd.repeat_str, repeat, sizeof(key->u.kbd.repeat_str));






\
 
 \ /
  Last update: 2012-07-11 03:01    [W:0.166 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site