Messages in this thread | | | Date | Tue, 10 Jul 2012 10:12:17 -0700 | Subject | Re: [PATCH] x86/mce: Need to let kill_proc() send signal to doomed process | From | Tony Luck <> |
| |
On Tue, Jul 10, 2012 at 8:44 AM, Borislav Petkov <bp@amd64.org> wrote: > Acked-by: Borislav Petkov <borislav.petkov@amd.com>
Thanks for the Ack.
+ doit = !!PageDirty(ppage) || !!(flags & MF_MUST_KILL);
Thinking about this some more, the "!!" are redundant and are an impediment to readability. We started with !!PageDirty(ppage) when we were passing an argument directly to kill_procs() and wanted to make sure we had a nice boolean value. But the result of the "||" is boolean, so we don't need to double negate.
I'm going to change it to: doit = PageDirty(ppage) || (flags & MF_MUST_KILL);
-Tony
| |