lkml.org 
[lkml]   [2012]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] nfs-util: Add cache_flush in mountd UMNT procedure.
On Sat, Jul 07, 2012 at 11:17:39PM -0400, Namjae Jeon wrote:
> For removing storage device - user needs to safely un-mount the device
> and then eject. But if 'EBUSY' occurs in umount then it will create
> confusion for the user as it will mean some I/O is in progress - and
> won't allow user to safely ejecting device.

The one drawback is that recovering from the cache flushes might be a
little expensive if you have a lot of exports in use.

I'm curious, since you said this was for a usb disk: are users expected
to just unplug it (in which case--is it read only?) or do they have some
way of unmounting before they pull the plug?

--b.

>
> 1. Without this patch:
>
> On NFS Client:
> $ mount.nfs <NFS_SERVER>:/mnt /mnt
> $ umount.nfs /mnt
>
> On NFS Server:
> $ umount /mnt
> umount: can't umount /mnt: Device or resource busy
>
> 2. With this patch:
>
> On NFS Client:
> $ mount.nfs <NFS_SERVER>:/mnt /mnt
> $ umount.nfs /mnt
>
> On NFS Server:
> $ umount.nfs /mnt --> umount successful
>
> Signed-off-by: Namjae Jeon <linkinjeon@gmail.com>
> Signed-off-by: Vivek Trivedi <vtrivedi018@gmail.com>
> ---
> utils/mountd/mountd.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/utils/mountd/mountd.c b/utils/mountd/mountd.c
> index bcf5080..2b190fb 100644
> --- a/utils/mountd/mountd.c
> +++ b/utils/mountd/mountd.c
> @@ -275,6 +275,7 @@ mount_umnt_1_svc(struct svc_req *rqstp, dirpath *argp, void *UNUSED(resp))
> return 1;
>
> mountlist_del(host_ntop(sap, buf, sizeof(buf)), p);
> + cache_flush(1);
> return 1;
> }
>
> @@ -292,6 +293,7 @@ mount_umntall_1_svc(struct svc_req *rqstp, void *UNUSED(argp),
> auth_reload();
>
> mountlist_del_all(nfs_getrpccaller(rqstp->rq_xprt));
> + cache_flush(1);
> return 1;
> }
>
> --
> 1.7.9.5
>


\
 
 \ /
  Last update: 2012-07-10 18:21    [from the cache]
©2003-2011 Jasper Spaans