lkml.org 
[lkml]   [2012]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 0/2] [V4] block: Support online resize of disk partitions
    On Tue, Jul 10, 2012 at 10:13:19AM -0400, Phillip Susi wrote:
    > -----BEGIN PGP SIGNED MESSAGE-----
    > Hash: SHA1
    >
    > On 7/10/2012 9:57 AM, Vivek Goyal wrote:
    > > +static inline sector_t part_nr_sects_read(struct hd_struct *part)
    > > +{ +#if BITS_PER_LONG==32 && defined(CONFIG_LBDAF) &&
    > > defined(CONFIG_SMP) + sector_t nr_sects; + unsigned seq; + do { +
    > > seq = read_seqcount_begin(&part->nr_sects_seq); + nr_sects =
    > > part->nr_sects; + } while (read_seqcount_retry(&part->nr_sects_seq,
    > > seq)); + return nr_sects; +#elif BITS_PER_LONG==32 &&
    > > defined(CONFIG_PREEMPT)
    >
    > Shouldn't this be BITS_PER_LONG==32 && defined(CONFIG_LBDAF) &&
    > defined(CONFIG_PREEMPT)? No sense disabling preemption when the
    > sector size is also 32 bits.

    Yes. Good catch. We don't want to disable/enable preemption for 32bit UP
    kernels with sector size 32bit. I will modify the patch and repost soon.

    BTW, what happened to all the new lines in the code above. Looks like you
    mailer chewed these up.

    Thanks
    Vivek


    \
     
     \ /
      Last update: 2012-07-10 17:01    [W:0.056 / U:60.268 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site