lkml.org 
[lkml]   [2012]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/3] shmem: cleanup shmem_add_to_page_cache
    On Mon, Jul 09, 2012 at 03:46:53PM -0700, Hugh Dickins wrote:
    > shmem_add_to_page_cache() has three callsites, but only one of them
    > wants the radix_tree_preload() (an exceptional entry guarantees that
    > the radix tree node is present in the other cases), and only that site
    > can achieve mem_cgroup_uncharge_cache_page() (PageSwapCache makes it a
    > no-op in the other cases). We did it this way originally to reflect
    > add_to_page_cache_locked(); but it's confusing now, so move the
    > radix_tree preloading and mem_cgroup uncharging to that one caller.
    >
    > Signed-off-by: Hugh Dickins <hughd@google.com>
    > Cc: Johannes Weiner <hannes@cmpxchg.org>
    > Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
    > Cc: Michal Hocko <mhocko@suse.cz>

    Acked-by: Johannes Weiner <hannes@cmpxchg.org>

    I'm rebasing my (un)charge series on top of these, thanks. It only
    annihilates 3/11 and leaves the rest alone--line numbers aside--since
    the rules did not change.


    \
     
     \ /
      Last update: 2012-07-10 15:41    [W:0.030 / U:0.020 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site