lkml.org 
[lkml]   [2012]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] net: cgroup: fix access the unallocated memory in netprio cgroup
    于 2012年07月10日 17:15, Eric Dumazet 写道:
    > On Tue, 2012-07-10 at 16:53 +0800, Gao feng wrote:
    >>> Hi Gao
    >>>
    >>> Is it still needed to call update_netdev_tables() from write_priomap() ?
    >>>
    >>
    >> Yes, I think it's needed,because read_priomap will show all of the net devices,
    >>
    >> But we may add the netdev after create a netprio cgroup, so the new added netdev's
    >> priomap will not be allocated. if we don't call update_netdev_tables in write_priomap,
    >> we may access this unallocated memory.
    >>
    >
    > I realize my question was not clear.
    >
    > If we write in write_priomap() a field of a single netdevice,
    > why should we allocate memory for all netdevices on the machine ?
    >
    > So the question was : Do we really need to call
    > update_netdev_tables(alldevs), instead of extend_netdev_table(dev)
    >
    >

    I get it.

    You are right,Indeed we only need to call extend_netdev_table
    for the netdev witch we want to change.

    and I read the commit f5c38208d32412d72b97a4f0d44af0eb39feb20b,
    found why we need delay allocation.

    I will send a v2 patch.

    Thanks!
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-07-10 12:22    [W:0.025 / U:29.964 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site