lkml.org 
[lkml]   [2012]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2 2/2] staging/comedi/drivers: free allocated priv and release resources if comedi_alloc_subdevices
On Sun, Jul 01, 2012 at 07:12:07PM +0530, Devendra Naga wrote:
> as comedi_alloc_subdevices may fail, we leak out the memory allocated by alloc_private,
> and also the I/O regions we requested.
>
> free out the private data pointer of the driver, and release the I/O regions.
>
> Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>

This breaks the build.

Also Hartley and Ian, what's the point of alloc_private()? It's
just hiding stuff which we need to know about and use later on
anyway.

regards,
dan carpenter




\
 
 \ /
  Last update: 2012-07-01 18:21    [from the cache]
©2003-2011 Jasper Spaans