Messages in this thread |  | | | Date | Sun, 1 Jul 2012 18:32:18 +0300 | | From | Dan Carpenter <> | | Subject | Re: [PATCH V2 2/2] staging/comedi/drivers: free allocated priv and release resources if comedi_alloc_subdevices |
| |
On Sun, Jul 01, 2012 at 07:12:07PM +0530, Devendra Naga wrote: > as comedi_alloc_subdevices may fail, we leak out the memory allocated by alloc_private, > and also the I/O regions we requested. > > free out the private data pointer of the driver, and release the I/O regions. > > Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
This breaks the build.
Also Hartley and Ian, what's the point of alloc_private()? It's just hiding stuff which we need to know about and use later on anyway.
regards, dan carpenter
|  |