Messages in this thread | | | From | Axel Lin <> | Date | Sun, 1 Jul 2012 17:53:25 +0800 | Subject | Re: [PATCH v2 2/3] pwm: Convert pwm-pxa to use devm_* APIs |
| |
>> - pwmchip_remove(&chip->chip); >> - >> - iounmap(chip->mmio_base); >> - >> - r = platform_get_resource(pdev, IORESOURCE_MEM, 0); >> - release_mem_region(r->start, resource_size(r)); >> - >> - clk_put(chip->clk); >> - kfree(chip); >> - return 0; >> + return pwmchip_remove(&chip->chip); > > What I meant was that this driver didn't return an error on failure of > pwmchip_remove() before so incorporating this change is unrelated to > this patch. Either make it a separate patch (preferably) or at least > mention it in the commit message. Oh. I just thought it is a trivial change and it probably ok to do so. Anyway, Since you prefer having this change in a separate patch, I'd send a v3 that leave this part unchanged.
Regards, Axel
> > Thierry
| |