lkml.org 
[lkml]   [2012]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 24/24] TTY: use tty_port_register_device
    On 06/04/2012 07:00 PM, Alan Cox wrote:
    >> In this patch we modify most of the drivers to do the latter. When the
    >> drivers use tty_register_device and we have tty_port already, we
    >> switch to tty_port_register_device. So we have the tty_struct =>
    >> tty_port link for free for those.
    >
    > Nice solution

    Seems so on the first glance... But it is racy. There is a window since
    tty_register_driver to tty_(port_)register_device where a node may be
    opened already, but tty_port won't be set up yet.

    The fix is to move cdev_add from tty_register_driver to
    tty_register_device, which makes sense anyway. Any objections?

    For the time being, Greg, please ignore 24/24 from these series (I see
    you haven't applied any of the patches yet.)

    thanks,
    --
    js
    suse labs




    \
     
     \ /
      Last update: 2012-06-09 17:21    [W:0.023 / U:1.092 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site