[lkml]   [2012]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH -V8 02/16] hugetlb: don't use ERR_PTR with VM_FAULT* values
    Konrad Rzeszutek Wilk <> writes:

    > On Sat, Jun 09, 2012 at 02:29:47PM +0530, Aneesh Kumar K.V wrote:
    >> From: "Aneesh Kumar K.V" <>
    >> The current use of VM_FAULT_* codes with ERR_PTR requires us to ensure
    >> VM_FAULT_* values will not exceed MAX_ERRNO value. Decouple the
    >> VM_FAULT_* values from MAX_ERRNO.
    > I see you using the -ENOMEM|-ENOSPC, but I don't see any reference in the
    > code to MAX_ERRNO? Can you provide a comment explaining in a tad little
    > bit about the interaction of MAX_ERRNO and VM_FAULT?

    That comes from this

    #define IS_ERR_VALUE(x) unlikely((x) >= (unsigned long)-MAX_ERRNO)


     \ /
      Last update: 2012-06-09 16:01    [W:0.022 / U:10.756 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site