lkml.org 
[lkml]   [2012]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -V8 14/16] hugetlb/cgroup: add charge/uncharge calls for HugeTLB alloc/free
On Sat, Jun 09, 2012 at 02:29:59PM +0530, Aneesh Kumar K.V wrote:
> From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
>
> This adds necessary charge/uncharge calls in the HugeTLB code. We do
> hugetlb cgroup charge in page alloc and uncharge in compound page destructor.
>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
> ---
> mm/hugetlb.c | 16 +++++++++++++++-
> mm/hugetlb_cgroup.c | 7 +------
> 2 files changed, 16 insertions(+), 7 deletions(-)
>
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index bf79131..4ca92a9 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -628,6 +628,8 @@ static void free_huge_page(struct page *page)
> BUG_ON(page_mapcount(page));
>
> spin_lock(&hugetlb_lock);
> + hugetlb_cgroup_uncharge_page(hstate_index(h),
> + pages_per_huge_page(h), page);

hugetlb_cgroup_uncharge_page() takes the hugetlb_lock, no?

It's quite hard to review code that is split up like this. Please
always keep the introduction of new functions in the same patch that
adds the callsite(s).


\
 
 \ /
  Last update: 2012-06-09 12:02    [from the cache]
©2003-2011 Jasper Spaans