Messages in this thread Patch in this message | | | From | Sasha Levin <> | Subject | [PATCH v2 06/10] mm: frontswap: make all branches of if statement in put page consistent | Date | Fri, 8 Jun 2012 21:15:15 +0200 |
| |
Currently it has a complex structure where different things are compared at each branch. Simplify that and make both branches look similar.
Signed-off-by: Sasha Levin <levinsasha928@gmail.com> --- mm/frontswap.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/mm/frontswap.c b/mm/frontswap.c index 1f1af0e..ee1763d 100644 --- a/mm/frontswap.c +++ b/mm/frontswap.c @@ -140,16 +140,16 @@ int __frontswap_store(struct page *page) inc_frontswap_succ_stores(); if (!dup) atomic_inc(&sis->frontswap_pages); - } else if (dup) { + } else { /* failed dup always results in automatic invalidate of the (older) page from frontswap */ - frontswap_clear(sis, offset); - atomic_dec(&sis->frontswap_pages); - inc_frontswap_failed_stores(); - } else inc_frontswap_failed_stores(); + if (dup) { + frontswap_clear(sis, offset); + atomic_dec(&sis->frontswap_pages); + } } if (frontswap_writethrough_enabled) /* report failure so swap also writes to swap device */ -- 1.7.8.6
| |