Messages in this thread |  | | | Date | Fri, 08 Jun 2012 13:00:00 +0200 | | From | Jiri Slaby <> | | Subject | Re: [PATCH] delete seven tty headers |
| |
On 06/08/2012 10:56 AM, Paul Bolle wrote: > 0) Tested with "git grep" only (by grepping on the file names). I > haven't grepped on the many things these headers provide (mostly named > constants). Some of these looked rather generic. Most of these headers > were relevant for builds I don't have the toolchains for at hand. And, > finally, I couldn't think of a way the things these headers provide > could still actually be used in the tree. > > But would you prefer further tests?
Nope, it's enough to know nobody in the kernel includes them.
> 1) cdk.h, comstats.h, istallion.h, and stallion.h are still referenced > in Documentation/ioctl/ioctl-number.txt and > Documentation/magic-number.txt. Should those references be deleted too?
Yes, please.
> --- a/include/linux/Kbuild > +++ b/include/linux/Kbuild > @@ -84,7 +84,6 @@ header-y += capability.h > header-y += capi.h > header-y += cciss_defs.h > header-y += cciss_ioctl.h > -header-y += cdk.h > header-y += cdrom.h > header-y += cgroupstats.h > header-y += chio.h > @@ -93,7 +92,6 @@ header-y += cn_proc.h > header-y += coda.h > header-y += coda_psdev.h > header-y += coff.h > -header-y += comstats.h > header-y += connector.h > header-y += const.h > header-y += cramfs_fs.h
NACK for these two files. I rather prefer going through the deprecate-wait_years-delete path (removal of __KERNEL__ parts, if there are any, is OK). I doubt there are any users at all, but we still should gave them a chance to fix their builds (remove those #include's and potentially used defined/structs) and not introduce a userspace build breakage.
The rest is OK to be removed.
thanks, -- js suse labs
|  |