lkml.org 
[lkml]   [2012]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] gpiolib: wm8994: Pay attention to the value set when enabling as output
    From
    On Thu, Jun 7, 2012 at 11:53 PM, Mark Brown
    <broonie@opensource.wolfsonmicro.com> wrote:

    >> Could you elaborate on the problem ans symptoms, just for a nice
    >> commit log?
    >
    > I'm not really sure what more there is to say...

    But you do ;-)

    > previously we were
    > ignoring the value that's set as part of setting output mode so if
    > someone wanted to set a value different to the one the chip happened to
    > have that wouldn't happen.  Ignoring the vaue that the user is trying to
    > set seems like an obvious enough bug in itself.

    Throw that into the commit message and I'm in for it!
    Acked-by: Linus Walleij <linus.walleij@linaro.org>

    Yours,
    Linus Walleij
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-06-08 11:41    [W:0.023 / U:0.080 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site