Messages in this thread Patch in this message | | | Date | Thu, 07 Jun 2012 13:03:37 +0900 | From | Greg KH <> | Subject | [ 01/82] exofs: Fix CRASH on very early IO errors. |
| |
3.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Boaz Harrosh <bharrosh@panasas.com>
commit 6abe4a87f7bc7978705c386dbba0ca0c7790b3ec upstream.
If at exofs_fill_super() we had an early termination do to any error, like an IO error while reading the super-block. We would crash inside exofs_free_sbi().
This is because sbi->oc.numdevs was set to 1, before we actually have a device table at all.
Fix it by moving the sbi->oc.numdevs = 1 to after the allocation of the device table.
Reported-by: Johannes Schild <JSchild@gmx.de>
Signed-off-by: Boaz Harrosh <bharrosh@panasas.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
--- fs/exofs/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/fs/exofs/super.c +++ b/fs/exofs/super.c @@ -745,7 +745,6 @@ static int exofs_fill_super(struct super sbi->one_comp.obj.partition = opts->pid; sbi->one_comp.obj.id = 0; exofs_make_credential(sbi->one_comp.cred, &sbi->one_comp.obj); - sbi->oc.numdevs = 1; sbi->oc.single_comp = EC_SINGLE_COMP; sbi->oc.comps = &sbi->one_comp; @@ -804,6 +803,7 @@ static int exofs_fill_super(struct super goto free_sbi; ore_comp_set_dev(&sbi->oc, 0, od); + sbi->oc.numdevs = 1; } __sbi_read_stats(sbi);
| |