lkml.org 
[lkml]   [2012]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/3] staging: zram: conventions, line splitting
From
Date
On Thu, 2012-06-07 at 13:20 -0700, Sam Hansen wrote:
> Opting to violate the 80-char limit in favor of not splitting strings onto
> multiple lines (via pr_info()). This mostly to help readability.
[]
> diff --git a/drivers/staging/zram/zram_drv.c b/drivers/staging/zram/zram_drv.c
[]
> @@ -390,8 +390,7 @@ static int zram_bvec_write(struct zram *zram, struct bio_vec *bvec, u32 index,
> clen = PAGE_SIZE;
> page_store = alloc_page(GFP_NOIO | __GFP_HIGHMEM);
> if (unlikely(!page_store)) {
> - pr_info("Error allocating memory for "
> - "incompressible page: %u\n", index);
> + pr_info("Error allocating memory for incompressible page: %u\n", index);

Hi Sam.

The general use has been to allow the format string to exceed
80 columns, but not any additional arguments on the same line.

i.e. it's more conformant to use:

pr_info("Error allocating memory for incompressible page: %u\n",
index);




\
 
 \ /
  Last update: 2012-06-07 23:41    [W:0.105 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site