Messages in this thread | | | Date | Thu, 7 Jun 2012 15:35:49 +0200 | From | Borislav Petkov <> | Subject | Re: [patch 0/5] x86: mce: Bugfixes, cleanups and a new CMCI poll version |
| |
On Thu, Jun 07, 2012 at 06:08:15PM +0800, Chen Gong wrote: > But during the CPU online/offline test I found an issue. After *STORM* > mode is entered, it can't come back from *STORM* mode to normal > interrupt mode. At least there exists such an issue: when *STORM* is > entered, in the meanwhile, one CPU is offline during this period, > which means *cmci_storm_on_cpus* can't decrease to 0 because there is > one bit stuck on this offlined CPU.
Stupid question: do you even want to allow offlining of CPUs while the storm is raging? IOW, wouldn't it be better to disallow hotplug when the storm happens so that all online CPUs, which is all CPUs on the system, can work out the storm conditions faster so that the system gets back to normal faster...
Thanks.
-- Regards/Gruss, Boris.
Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach GM: Alberto Bozzo Reg: Dornach, Landkreis Muenchen HRB Nr. 43632 WEEE Registernr: 129 19551
| |