lkml.org 
[lkml]   [2012]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [GIT PULL 00/15] perf/urgent fixes
    Date
    Hi, David

    On Wed, 06 Jun 2012 16:50:31 -0600, David Ahern wrote:
    > On 6/6/12 12:50 AM, Ingo Molnar wrote:
    >> Hm, I got this build failure:
    >>
    >> bench/mem-memcpy.c: In function ‘bench_mem_memcpy’:
    >> bench/mem-memcpy.c:193:2: error: implicit declaration of function ‘perf_atoll’ [-Werror=implicit-function-declaration]
    >> bench/mem-memcpy.c:193:2: error: nested extern declaration of ‘perf_atoll’ [-Werror=nested-externs]
    >
    > I just created a new F17-x86_64 VM and Arnaldo's perf/urgent branch
    > builds fine (which includes this patch).
    >

    I can reproduce it on my F17-x86_64 - current tip + your patch gives:

    $ make
    PERF_VERSION = 3.5.rc1.99.g7ac4a
    CC perf.o
    CC builtin-annotate.o
    CC builtin-bench.o
    CC bench/sched-messaging.o
    CC bench/sched-pipe.o
    CC bench/mem-memcpy-x86-64-asm.o
    CC bench/mem-memset-x86-64-asm.o
    CC bench/mem-memcpy.o
    bench/mem-memcpy.c: In function ‘bench_mem_memcpy’:
    bench/mem-memcpy.c:193:2: error: implicit declaration of function ‘perf_atoll’ [-Werror=implicit-function-declaration]
    bench/mem-memcpy.c:193:2: error: nested extern declaration of ‘perf_atoll’ [-Werror=nested-externs]
    cc1: all warnings being treated as errors
    make: *** [bench/mem-memcpy.o] Error 1



    >>
    >> Which appears to be a result of:
    >>
    >> 6b7df4a0237a perf tool: Build fix, remove duplicate declarations
    >>
    >> Those declarations were not so unused on this fresh install of
    >> Fedora 17.
    >
    > 32-bit? 64-bit?
    >
    > This would fix your compile problem, but I have no way of verifying
    > since it builds fine for me.
    >
    > diff --git a/tools/perf/bench/mem-memcpy.c b/tools/perf/bench/mem-memcpy.c
    > index 7155722..535b4b8 100644
    > --- a/tools/perf/bench/mem-memcpy.c
    > +++ b/tools/perf/bench/mem-memcpy.c
    > @@ -10,6 +10,7 @@
    > #include "../util/util.h"
    > #include "../util/parse-options.h"
    > #include "../util/header.h"
    > +#include "../util/string.h"
    > #include "bench.h"
    > #include "mem-memcpy-arch.h"

    After applying this (on top of your patch):

    $ make
    PERF_VERSION = 3.5.rc1.99.g7ac4a.dirty
    CC perf.o
    CC bench/mem-memcpy.o
    bench/mem-memcpy.c:13:28: fatal error: ../util/string.h: No such file or directory
    compilation terminated.
    make: *** [bench/mem-memcpy.o] Error 1

    Thanks,
    Namhyung
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-06-07 05:01    [W:3.729 / U:1.268 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site