Messages in this thread |  | | | Date | Wed, 6 Jun 2012 15:50:56 -0700 | | From | Andrew Morton <> | | Subject | Re: [PATCH v4] remove no longer use of pdflush interface |
| |
On Wed, 6 Jun 2012 21:38:08 +0800 Wanpeng Li <liwp.linux@gmail.com> wrote:
> From: Wanpeng Li <liwp@linux.vnet.ibm.com> > > Since per-BDI flusher introduced to linux 2.6, pdflush mechanism is not > used any more. But the old interface of pdflush exported in/proc/sys/vm/ > is still there. In order to take attention to back-compatibility issues, > printk warning information and return -ENOSYS to notice the users the > interface is removed. > > ... > > +/* notice associated proc obsoleted */
This comment is pretty meaningless - I suggest simply removing it.
> +int pdflush_proc_obsolete(struct ctl_table *table, int write, > + void __user *buffer, size_t *lenp, loff_t *ppos) > +{ > + printk_once(KERN_WARNING "%s exported in /proc is scheduled for removal\n", > + table->procname); > + return -ENOSYS; > +}
No, this immediately breaks /proc/sys/vm/nr_pdflush_threads users. To preserve back-compatibility we should copy "0\n" out to userspace and return 2.
> +EXPORT_SYMBOL(pdflush_proc_obsolete);
This export isn't needed?
|  |