lkml.org 
[lkml]   [2012]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 7/7] drivers/net/can/cc770/cc770_platform.c: adjust suspicious bit operation
    Date
    From: Julia Lawall <Julia.Lawall@lip6.fr>

    CPUIF_DSC is 0x40, so it would seem that & is wanted rather than |.

    This problem was found using Coccinelle (http://coccinelle.lip6.fr/).

    Signed-off-by: Julia Lawall <julia@diku.dk>

    ---
    drivers/net/can/cc770/cc770_platform.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/can/cc770/cc770_platform.c b/drivers/net/can/cc770/cc770_platform.c
    index 53115ee..688371c 100644
    --- a/drivers/net/can/cc770/cc770_platform.c
    +++ b/drivers/net/can/cc770/cc770_platform.c
    @@ -154,7 +154,7 @@ static int __devinit cc770_get_platform_data(struct platform_device *pdev,
    struct cc770_platform_data *pdata = pdev->dev.platform_data;

    priv->can.clock.freq = pdata->osc_freq;
    - if (priv->cpu_interface | CPUIF_DSC)
    + if (priv->cpu_interface & CPUIF_DSC)
    priv->can.clock.freq /= 2;
    priv->clkout = pdata->cor;
    priv->bus_config = pdata->bcr;


    \
     
     \ /
      Last update: 2012-06-07 00:21    [W:0.023 / U:0.704 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site