lkml.org 
[lkml]   [2012]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 01/11] fix wrong label in skel_open
Date
Am Mittwoch, 6. Juni 2012, 18:27:02 schrieb stefani@seibold.net:
> From: Stefani Seibold <stefani@seibold.net>

Thank you for putting the effort to even split this up.
It makes it much easier to review.

> Signed-off-by: Stefani Seibold <stefani@seibold.net>
> ---
> drivers/usb/usb-skeleton.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/usb-skeleton.c b/drivers/usb/usb-skeleton.c
> index 0616f23..a57f1d2 100644
> --- a/drivers/usb/usb-skeleton.c
> +++ b/drivers/usb/usb-skeleton.c
> @@ -114,7 +114,7 @@ static int skel_open(struct inode *inode, struct file *file)
>
> retval = usb_autopm_get_interface(interface);
> if (retval)
> - goto out_err;
> + goto exit;

Are you removing io_mutex? If not, the correct fix is a second label
to drop the lock, not changing the label.

Regards
Oliver


\
 
 \ /
  Last update: 2012-06-06 21:41    [W:3.867 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site